Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model organisms other than human #5

Closed
maxkfranz opened this issue Mar 6, 2019 · 6 comments
Closed

Add support for model organisms other than human #5

maxkfranz opened this issue Mar 6, 2019 · 6 comments
Assignees

Comments

@maxkfranz
Copy link
Member

No description provided.

@maxkfranz maxkfranz changed the title Add support for other model organisms Add support for model organisms other than human Mar 6, 2019
@metincansiper
Copy link
Contributor

@maxkfranz Should all of the organizms be enabled with no check at all? Or only the ones supported by factoid (https://github.com/PathwayCommons/factoid/blob/master/src/model/organism.js#L59) must be enabled (I am actually not sure if the factoid already support all organisms)?

@maxkfranz
Copy link
Member Author

Let's start with just the list that Factoid supports.

@metincansiper
Copy link
Contributor

Okay, I did so. Looks like nothing is broken after the related commit.

@metincansiper
Copy link
Contributor

However, as far as I can understand these organism ids are not specific to uniprot. If that is true it would make sense if I move supported organism ids list to a more general file from the uniprot file.

@maxkfranz
Copy link
Member Author

Yes, they're taxon ids -- which are not specific to uniprot.

@metincansiper
Copy link
Contributor

Okay, thanks. I updated as I mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants