This repository has been archived by the owner on May 11, 2022. It is now read-only.
Depend on ActiveSupport 3.2, remove deprecated Instancemethods #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if somebody can marge this in? |
|
Would love this merged as well. :) |
|
FWIW, Rails 3.1+ has the functionality of no-peeping-toms baked in: https://github.com/rails/rails/blob/v3.1.0/activemodel/lib/active_model/observer_array.rb#L18-63 |
|
@myronmarston That's awesome, thanks! |
|
@myronmarston thanks, didn't know this feature. Great work on the Rails patch. :) |
|
@myronmarston Thanks. Haven't seen that. |
|
handled by #25 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InstanceMethodsis deprecated in ActiveSupport 3.2.This PR updates it accordingly.
The workaround is to use my branch:
gem 'no_peeping_toms', :git => 'git://github.com/dnagir/no-peeping-toms.git', :branch => 'activesupport-3.2'