Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all fonts from example page (patorjk.com) #3

Closed
eiriksm opened this issue May 27, 2014 · 4 comments
Closed

Include all fonts from example page (patorjk.com) #3

eiriksm opened this issue May 27, 2014 · 4 comments

Comments

@eiriksm
Copy link
Contributor

eiriksm commented May 27, 2014

Hi there, and thanks for a kick ass module.

I was wondering if there were any reason as to why you did not include all the same fonts from the website in this module. For example the "Ansi Figlet Fonts" that you have on http://patorjk.com/software/taag

If there is some kind of licence or something, or if there is another reason?

@patorjk
Copy link
Owner

patorjk commented May 27, 2014

hey eiriksm,

No licensing issues. The 10 ANSI Art fonts are listed in the fonts directory:

https://github.com/patorjk/figlet.js/tree/master/fonts

However, I haven't done an update to the module on npm to include those 10 fonts. I was working on an update earlier this year and just got sidetracked. Either tonight or tomorrow night I'll revisit what I've done and update the npm module.

@eiriksm
Copy link
Contributor Author

eiriksm commented May 27, 2014

Ah, I see. How foolish of me to not look in there in the master branch as well :)

I'll send in a few pull requests in a few, by the way ;)

@eiriksm
Copy link
Contributor Author

eiriksm commented Jun 7, 2014

Howdy. Just a little bump on this thread. I am using this for some stuff I am developing, and I rather link to the npm module than the git repo :p

@patorjk
Copy link
Owner

patorjk commented Jun 7, 2014

Sorry about that, and thanks for reminding me! I've updated npm so it now has the new fonts. The new version is 1.0.9.

@patorjk patorjk closed this as completed Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants