Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json files for other UA force fields and lipids #44

Open
patrickfuchs opened this issue Jan 4, 2021 · 8 comments
Open

Add json files for other UA force fields and lipids #44

patrickfuchs opened this issue Jan 4, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@patrickfuchs
Copy link
Owner

So far in dic_lipid.py, we have only one UA lipid : Berger POPC. We also have CHARMM36-AA POPC, but it's an AA force field. This lipid is there because it was used to test whether the reconstruction from buildH gave a good match compared to an all-atom force field such as CHARMM36-AA.
In this issue, I suggest to extend dic_lipids.py to :

We shall use autolipmap for building automatically these dictionnaries.

@patrickfuchs
Copy link
Owner Author

Samuli Ollila forked buildH and expanded dic_lipids.py for some other UA force fields : NMRLipids@d0a2bc1
So before adding new stuff to dic_lipids.py, we shall restart from Samuli's version.

@HubLot
Copy link
Collaborator

HubLot commented Jan 5, 2021

We could cherry pick his commit and add it to master through a branch (like this)

@patrickfuchs
Copy link
Owner Author

Waoo, very impressive technique 😎 !!!

@HubLot
Copy link
Collaborator

HubLot commented Jan 7, 2021

I'm on it, should we add also into this repo the others def files from this commit or is it unnecessary?
(I think it's not needed)

@patrickfuchs
Copy link
Owner Author

Well, in principle all lipids in dic_lipids.py should have the corresponding def file. So in principle I'd say yes, unless it's just another residue name and we can use the trick Berger_PLA = copy.deepcopy(Berger_POPC).
I'm thinking now, maybe we should find a way to synchronize the def file from the MATCH repo (https://github.com/NMRLipids/MATCH/tree/master/scripts/orderParm_defs) ? This is something we can discuss with Samuli, that'd be nice to have these .def files at a well defined place, rather than randomly trying to edit them from repo to repo.

@patrickfuchs patrickfuchs self-assigned this Apr 16, 2021
@HubLot HubLot added the enhancement New feature or request label Apr 16, 2021
@patrickfuchs patrickfuchs changed the title Extend dic_lipid.py for other UA force fields and lipids Add json files for other UA force fields and lipids May 11, 2021
@patrickfuchs
Copy link
Owner Author

patrickfuchs commented May 21, 2021

I just added Berger POPE. I'm almost finished with Berger cholesterol. I put a check list of the lipids (+ a Zenodo link to a traj example) that would be nice to add (the most important ones are highlighted) :

Berger

GROMOS-CKP

GROMOS 53A6L

CHARMM36-UA

CHARMM36 (only for validation purpose since there already H in there 😉)

  • POPC

@ohsOllila
Copy link

We have now progressed in adding also united atom trajectories in the NMRlipids databank with @larabort and we have come to the point that we would like to add trajectories for which json files are not yet available in here: https://github.com/patrickfuchs/buildH/tree/master/buildh/lipids

Specifically we would be currently interested to add the following lipids simulated with the Berger force field:

  1. DOPE
  2. DOPS
  3. DLPC
  4. DMPC
  5. DMTAP
  6. PAzePC

I believe that it would be straightforward for @larabort to create the json files for these, but how should we proceed in practice in adding those into the BuildH program?

@patrickfuchs
Copy link
Owner Author

It is always possible to build your own json file and supply it to buildh with the option -lt. However, if @larabort does this job, I think it could be useful to incorporate them in buildH so that they could be available for everyone. In this case, @larabort can do a PR. A couple of remarks if you'd like to PR though:

  • we incorporate new lipids json files which contain all possible Hs to reconstruct ;
  • a def file containing all possible C-H pairs to reconstruct should be provided too ;
  • the provided files should be checked carefully (one easy test is to reconstruct all H of a single lipid and carefully inspect the lipid with new Hs using Pymol or VMD).
    From my experience, it's easy to make a mistake when writing those files on new molecules without an existing model. When I see the lipids you need, you should be able to use the ones that already exist in buildH as templates. However, for info, we have an automatic procedure which uses autoLipMap. It was very useful for building the files for cholesterol. Of course, we can provide the scripts if needed. In such a case, don't hesitate to contact me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants