Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKit - logo: replace ratio property by width and height properties #1111

Closed
mfranzke opened this issue Dec 5, 2019 · 0 comments · Fixed by #1112
Closed

UIKit - logo: replace ratio property by width and height properties #1111

mfranzke opened this issue Dec 5, 2019 · 0 comments · Fixed by #1112

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Dec 5, 2019

I've recognized that there's a new option related to the logo to provide the ratio as a string, compare to https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/scripts/lit-components/pl-logo/pl-logo.js - but it seems that the ratio isn't being used/set in that component.

I'd like to suggest to change the "ratio" property to both "width" and "height" properties with their equivalent HTML attributes being used, as the browser determines the aspectratio itself nowadays (as suggested by Jen Simmons, see e.g. https://css-tricks.com/what-if-we-got-aspect-ratio-sized-images-by-doing-almost-nothing/).

I'll open a PR for this.

sghoweri added a commit that referenced this issue Dec 19, 2019
feature: UIKit - logo: replaced ratio property #1111
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
…-width-height

feature: UIKit - logo: replaced ratio property pattern-lab#1111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant