feature: UIKit - logo: replaced ratio property #1111 #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghoweri
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Thanks so much for this update @mfranzke! I went in add add the ifDefined directive from lit-html so these HTML attributes only get added when a value exists -- other than that this is good to go!
Side note: I know we'll need to add these two props to the new Logo component docs (coming very soon - promise!) but this is a great little update that should help reduce the amount of jumping around when Pattern Lab boots up! #perceivedPerformance 👍
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…-width-height feature: UIKit - logo: replaced ratio property pattern-lab#1111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1111
Summary of changes:
replaced
ratioproperty bywidthandheightproperties for the themes logo customization.