Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): set current working directory before scaffolded npm init #1150

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer commented Apr 24, 2020

Closes #1142

Summary of changes:

In my testing of production, running npm init patternlab prompts you to choose a directory,

If you choose to specify a directory (assuming to create a new one, in this case, we check for the presence of a package.json but then don't use that same path to run npm init if one is not found. Sure enough, the package.json is created in the calling directory, not the new one.

This change Attempts to set current working directory prior to project init.

I tried getting the scaffold tests to work but could not in limited time.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.406% when pulling 5993ebb on new-dir-init into aef661a on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit bb038a0 into dev Apr 24, 2020
@bmuenzenmeyer bmuenzenmeyer deleted the new-dir-init branch April 24, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create blank pattern-lab node from cli
2 participants