refactor: clearing floats in a modern way #1362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution with overflow(-x) leads to several problems, previously regarding
overflow
on absolutely positioned elements being cropped, and now elements that are positionedsticky
wouldn't work because of theoverflow-x
declaration.Closes #1361
Summary of changes:
As we don't want to actually control any overflow here, but mainly clear the remaining defined floats by the components, it might be much better to switch to an actual
clearfix
.