Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes undefined return in @pattern-lab/cli version.js #865

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Fixes undefined return in @pattern-lab/cli version.js #865

merged 1 commit into from
Jun 9, 2018

Conversation

raphaelokon
Copy link
Contributor

@raphaelokon raphaelokon commented Jun 8, 2018 •
edited

Closes #862

Summary of changes:
Fixes arrow func not returning a value.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.361% when pulling 7b79bd9 on issue/862-cli-version into 11bc41b on dev.

bmuenzenmeyer
bmuenzenmeyer approved these changes Jun 9, 2018
View reviewed changes
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL concise function bodies have implied returns

👍 thanks for the quick turnaround @raphaelokon

@bmuenzenmeyer bmuenzenmeyer merged commit 7ca86a6 into dev Jun 9, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the issue/862-cli-version branch June 9, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raphaelokon @coveralls @bmuenzenmeyer