feat(tools): knobs #2781
Draft
feat(tools): knobs #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(clipboard-copy)!: remove BaseClipboardCopy Closes #2611 * fix(clipboard-copy): use pfv4 styles * fix(clipboard-copy)!: rename ClipboardCopyCopiedEvent to PfClipboardCopyCopiedEvent
* fix(switch)!: remove BaseSwitch Closes #2618 * fix(switch): remove extra semicolon * Merge branch 'staging/4.0' into fix/switch/remove-base * fix(switch): svg namespace --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2613 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
* fix(label)!: remove BaseLabel Closes #2620 * feat(label): self-remove on close * test(label): update tests * fix(label): correct font-size unit, include missing pf global var * docs(label): fix accesibility demo * fix(label): removes the removal of element and only triggers close event * fix(label): undo last commit, see the example in the changeset --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2614 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2615 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
* fix(card): moving styles and code from baseclass * chore: changset * feat(card): removing basecard class, styles * fix(card): remove unused basecard import * Update .changeset/sharp-spiders-float.md Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com> * docs: make changeset major * fix(card): make slot controller private * feat(card): title slot, header actions --------- Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com> Co-authored-by: Benny Powers <web@bennypowers.com>
* fix(icon)!: remove BaseIcon Closes #2621 * docs: jsdoc * fix(icon): base styles * docs: addIconSet jsdoc Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * docs: jsdoc for getIconUrl Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * style: lint * fix: remove baseicon from bad merge --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
wip dev server knobs
|
github-actions
bot
added
work in progress
* chore: lint massive lint. no more warnings * chore: update typescript enable `isolatedDeclarations`, which makes our dx a bit worse but improves downstream performance * chore: appease cupertino * chore: pkg lock
docs(button): custom roles
github-actions
bot
removed
doc
styles
bennypowers
requested review from
coreyvickery,
marionnegp,
zeroedin and
brianferry
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(tools): knobs"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
Notes to Reviewers