-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): internals form disabled update #2808
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(clipboard-copy)!: remove BaseClipboardCopy Closes #2611 * fix(clipboard-copy): use pfv4 styles * fix(clipboard-copy)!: rename ClipboardCopyCopiedEvent to PfClipboardCopyCopiedEvent
* fix(switch)!: remove BaseSwitch Closes #2618 * fix(switch): remove extra semicolon * Merge branch 'staging/4.0' into fix/switch/remove-base * fix(switch): svg namespace --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2613 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
* fix(label)!: remove BaseLabel Closes #2620 * feat(label): self-remove on close * test(label): update tests * fix(label): correct font-size unit, include missing pf global var * docs(label): fix accesibility demo * fix(label): removes the removal of element and only triggers close event * fix(label): undo last commit, see the example in the changeset --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2614 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2615 Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
* fix(card): moving styles and code from baseclass * chore: changset * feat(card): removing basecard class, styles * fix(card): remove unused basecard import * Update .changeset/sharp-spiders-float.md Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com> * docs: make changeset major * fix(card): make slot controller private * feat(card): title slot, header actions --------- Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com> Co-authored-by: Benny Powers <web@bennypowers.com>
* fix(icon)!: remove BaseIcon Closes #2621 * docs: jsdoc * fix(icon): base styles * docs: addIconSet jsdoc Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * docs: jsdoc for getIconUrl Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * style: lint * fix: remove baseicon from bad merge --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
* fix(accordion)!: remove BaseAccordion Closes #2612 fix(accordion): expand logic refactor(accordion): prevent circular imports * feat(tools): querySnapshot test helper * test(accordion): fix some tests * fix(accordion): single attribute
* fix(icon)!: remove getIconUrl for webpack's sake * test(icon): refactor tests * chore: update icons * docs(icon): fix custom sets demo * chore: update rhds dep
* fix(core)!: remove side effects from core import Removes `window.PfeConfig` and auto-reveal features Adds server checks to `createContextWithRoot` * feat(tools): ssr test page * test(accordion): ssr tests * test(avatar): ssr tests * test(back-to-top): ssr * test(background-image): ssr * test(badge): ssr * test(banner): ssr * test(button): ssr * test(card): ssr * test(chip): ssr * test(clipboard-copy): ssr * test(code-block): ssr * test(dropdown): ssr * test(icon): ssr * test(jump-links): ssr * test(label): ssr * test(modal): ssr * test(panel): ssr * test(popover): ssr * test(progress): ssr * test(progress-stepper): ssr * test(select): ssr * test(spinner): ssr * test(switch): ssr * test(table): ssr * test(tabs): ssr * test(text-area): ssr * test(text-area): ssr * test(tile): ssr * test(timestamp): ssr * test(tooltip): ssr * feat(create-element): ssr tests * feat(tools): automatic ssr demos * fix(tools): shim module * docs: changesets * test: remove cruft * fix(tools): ssr error reports * test: playwright config for ssr * chore: ssr test workflow * fix(tools): ssr error status message * chore: ssr test workflow * chore: ssr test workflow * chore: ignore reports * fix(accordion): ssrability * fix(back-to-top): ssrability * docs: jsdoc for ssr tests * chore: test workflow in ci * fix(core): fix Logger for ssr * style: whitespace * chore: better elements build * fix(core): more ssr-able controllers * test(back-to-top): ssrable demos * fix(tools): redirects for demos in dev server * fix(tools): ssr files * test(background-image): ssrable demos * fix(tools): 11ty demo images * fix(core): floating dom controller more ssrable * feat(tools): export ssr helpers * fix(code-block): ssrable * fix(jump-links): ssrable * fix(core): ssrable ScrollSpyController * fix(progress-stepper): ssrable * fix(popover): ssrable * fix(core): ssrable lbc * fix(icon): ssr * fix(select): ssrable * fix(table): ssrable * fix(text-area): ssrable * fix(text-input): ssrable * fix(tooltip): ssrable * chore: pr reports * fix(tools): update playwright * chore: ssr workflow * chore: ssr workflow * chore: actions versions * chore: ssr workflow * chore: ssr workflow * chore: ssr workflow * chore: ssr workflow * chore: ssr workflow * chore: ssr workflow * chore: ssr workflow
🦋 Changeset detectedLatest commit: f766ee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
functionality
Functionality, typically pertaining to the JavaScript.
styles
An issue or PR pertaining only to CSS/Sass
labels
Jul 9, 2024
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think there's a browser or spec issue here that needs fleshing out |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(core): internals form disabled update"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AT passed
Automated testing has passed
functionality
Functionality, typically pertaining to the JavaScript.
styles
An issue or PR pertaining only to CSS/Sass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
InternalsController
callrequestUpdate
informDisabledCallback
Testing Instructions
Notes to Reviewers