Pfe autocomplete updates #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starryeyez024
requested review from
castastrophe
and removed request for
starryeyez024
castastrophe
suggested changes
Oct 28, 2019
…ions; update demo page
|
@starryeyez024 @kylebuch8 Did you see there's this branch out there too for this work: https://github.com/patternfly/patternfly-elements/pull/331/files |
# Conflicts: # .storybook/utils.js # package-lock.json
…ete-updates # Conflicts: # elements/pfe-autocomplete/demo/pfe-autocomplete.story.js # elements/pfe-autocomplete/src/pfe-autocomplete.scss
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
…rint when category is passed in
…ernfly-elements into pfe-autocomplete-updates
Co-Authored-By: [ Cassondra ] <castastrophe@users.noreply.github.com>
castastrophe
reviewed
Nov 1, 2019
castastrophe
reviewed
Nov 1, 2019
castastrophe
reviewed
Nov 1, 2019
starryeyez024
previously approved these changes
Nov 1, 2019
castastrophe
reviewed
Nov 4, 2019
| @@ -73,7 +73,7 @@ $pfe-color--ui-disabled: $pfelements--gray-light !default | |||
| $pfe-color--ui-disabled--hover: $pfelements--gray-light !default; | |||
| $pfe-color--ui-disabled--focus: $pfelements--gray-light !default; | |||
| $pfe-color--ui-disabled--visited: $pfelements--gray-light !default; | |||
| $pfe-color--ui-disabled--text: $pfelements--gray !default; | |||
| $pfe-color--ui-disabled--text: $pfe-color--gray-600; | |||
There was a problem hiding this comment.
This still needs the !default value though
There was a problem hiding this comment.
@castastrophe - I just pushed the change that adds it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfe-autocomplete Angular support, story, and schema