Skip to content

Commit

Permalink
fix(tree-list): deprecated due to mobx autorun issues
Browse files Browse the repository at this point in the history
Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component.

Fixes #381
  • Loading branch information
dlabrecq committed Jun 15, 2018
1 parent 54d234e commit 54810b2
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/app/list/tree-list/tree-list-config.ts
Expand Up @@ -2,6 +2,11 @@ import { ListBaseConfig } from '../list-base-config';

/**
* A config containing properties for tree list
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
export class TreeListConfig extends ListBaseConfig {
/**
Expand Down
5 changes: 5 additions & 0 deletions src/app/list/tree-list/tree-list.component.ts
Expand Up @@ -34,6 +34,11 @@ import { TreeListConfig } from './tree-list-config';
*
* Or:
* <br/><code>import { TreeListModule } from 'patternfly-ng';</code>
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
@Component({
encapsulation: ViewEncapsulation.None,
Expand Down
12 changes: 11 additions & 1 deletion src/app/list/tree-list/tree-list.module.ts
Expand Up @@ -13,6 +13,11 @@ export {

/**
* A module containing objects associated with tree list components
*
* @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun,
* introduced by angular-tree-component.
*
* See: https://github.com/patternfly/patternfly-ng/issues/381
*/
@NgModule({
imports: [
Expand All @@ -24,4 +29,9 @@ export {
declarations: [TreeListComponent],
exports: [TreeListComponent]
})
export class TreeListModule {}
export class TreeListModule {
constructor() {
console.log('patternfly-ng: The tree-list component is deprecated due to issues with Angular 6 and ' +
'mobx autorun, introduced by angular-tree-component.');
}
}

0 comments on commit 54810b2

Please sign in to comment.