fix(Modal): ensure getElement does not return null (#4544)

* fix(Modal): ensure getElement does not return null * change default prop * fix snapshots
patternfly · Jul 28, 2020 · 358b0e2 · 358b0e2
1 parent 4deab01
commit 358b0e2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/react-core/src/components/Modal/Modal.tsx b/packages/react-core/src/components/Modal/Modal.tsx
@@ -79,7 +79,7 @@ export class Modal extends React.Component<ModalProps, ModalState> {
     onClose: () => undefined as any,
     variant: 'default',
     hasNoBodyWrapper: false,
-    appendTo: (typeof document !== 'undefined' && document.body) || null,
+    appendTo: () => document.body,
     ouiaSafe: true
   };
 
@@ -105,13 +105,10 @@ export class Modal extends React.Component<ModalProps, ModalState> {
   };
 
   getElement = (appendTo: HTMLElement | (() => HTMLElement)) => {
-    let target: HTMLElement;
     if (typeof appendTo === 'function') {
-      target = appendTo();
-    } else {
-      target = appendTo;
+      return appendTo();
     }
-    return target;
+    return appendTo || document.body;
   };
 
   toggleSiblingsFromScreenReaders = (hide: boolean) => {

diff --git a/...s/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/Wizard.test.tsx.snap b/...s/react-core/src/components/Wizard/__tests__/Generated/__snapshots__/Wizard.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`Wizard should match snapshot (auto-generated) 1`] = `
 <Modal
   actions={Array []}
-  appendTo={<body />}
+  appendTo={[Function]}
   aria-describedby="string"
   aria-label=""
   aria-labelledby="string"