Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated SFC syntax with FunctionComponent #1149

Closed
ibolton336 opened this issue Jan 9, 2019 · 2 comments
Closed

Replace deprecated SFC syntax with FunctionComponent #1149

ibolton336 opened this issue Jan 9, 2019 · 2 comments
Assignees
@nicolethoen
Labels
PF4 React issues for the PF4 core effort TypeScript

Comments

@ibolton336
Copy link
Member

We should change all instances of SFC to FunctionComponent to be consistent with typescript best practices

https://github.com/sw-yx/react-typescript-cheatsheet
@ibolton336 ibolton336 added PF4 React issues for the PF4 core effort TypeScript labels Jan 9, 2019
@ibolton336 ibolton336 mentioned this issue Jan 9, 2019
Merged
@dgutride dgutride added the p2 label Jan 15, 2019
@nicolethoen nicolethoen self-assigned this Jan 23, 2019
@nicolethoen nicolethoen mentioned this issue Jan 25, 2019
Merged
@tlabaj
Copy link
Contributor

tlabaj commented Jan 29, 2019

Closed by PR #1247

@tlabaj tlabaj closed this as completed Jan 29, 2019
@tlabaj tlabaj reopened this Jan 29, 2019
@nicolethoen nicolethoen mentioned this issue Jan 29, 2019
Merged
@rachael-phillips rachael-phillips added p1 and removed p2 labels Feb 4, 2019
@tlabaj
Copy link
Contributor

tlabaj commented Feb 4, 2019

Closed by PRs #1247 and #1276

@tlabaj tlabaj closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
PF4 React issues for the PF4 core effort TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dgutride @ibolton336 @nicolethoen @tlabaj @rachael-phillips