chore(generator): update generator to support typescript files #1143
Conversation
|
PatternFly-React preview: https://1143-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3857
💛 - Coveralls |
ibolton336
force-pushed
the
add-ts-to-generator
branch
from
29e7372
to
1ce677a
Compare
ibolton336
force-pushed
the
add-ts-to-generator
branch
from
1ce677a
to
bae45de
Compare
ibolton336
force-pushed
the
add-ts-to-generator
branch
from
ac66935
to
a95b686
Compare
| className ?: string; | ||
| } | ||
|
|
||
| const {{componentName}}: React.SFC <{{componentName}}Props> = (props) => ( |
There was a problem hiding this comment.
I actually just saw today on another project that React.SFC will be replaced by React.FunctionComponent in the future. Might be good to switch to that now. Also you might want to remove the space between SFC and < (React.FunctionComponent<{{componentName}}Props>) prettier will likely remove it after the fact, but it would be better to avoid needing the cleanup step.
There was a problem hiding this comment.
Looks good to me with the space removal - we should add an issue and make sure the FunctionComponent change above is good and make that change separately (to get this in and be consistent).
There was a problem hiding this comment.
@dgutride updated the PR to remove the spaces.
| className ?: string; | ||
| } | ||
|
|
||
| const {{componentName}}: React.SFC <{{componentName}}Props> = (props) => ( |
There was a problem hiding this comment.
Looks good to me with the space removal - we should add an issue and make sure the FunctionComponent change above is good and make that change separately (to get this in and be consistent).
ibolton336
force-pushed
the
add-ts-to-generator
branch
from
a95b686
to
e216677
Compare
|
Added an issue for the FunctionComponent changes #1149 |
|
looks good to me @ibolton336 👍 |
What: fix #1045
Additional issues: