Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Cancel button should be a LinkButton #2585

Closed
jschuler opened this issue Jul 24, 2019 · 3 comments · Fixed by #2979
Closed

Modal: Cancel button should be a LinkButton #2585

jschuler opened this issue Jul 24, 2019 · 3 comments · Fixed by #2979
Assignees
@boaz0
Labels
PF4 React issues for the PF4 core effort

Comments

@jschuler
Copy link
Collaborator

No description provided.

@jschuler jschuler added the PF4 React issues for the PF4 core effort label Jul 24, 2019
@boaz0
Copy link
Member

boaz0 commented Aug 5, 2019

Are you talking about the close button? The Modal doesn't have any cancel button.

@rachael-phillips
Copy link
Contributor

HI @jschuler is this still an issue?

@mcarrano
Copy link
Member

This is still an issue that was noted to me yesterday by one of our designers. Examples in the Modal should be updated to look like this:

Small

@boaz0 boaz0 mentioned this issue Sep 20, 2019
Merged
@tlabaj tlabaj removed the ux review label Sep 24, 2019
@tlabaj tlabaj assigned boaz0 and unassigned jschuler Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boaz0 boaz0

Labels
PF4 React issues for the PF4 core effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(modal): change the cancel button variant to link
5 participants
@jschuler @boaz0 @mcarrano @tlabaj @rachael-phillips