fix(dropdown): add focus trap option that allows close on click

[ibolton336]

What:
fixes #1113 and #1125

Additional issues:

[coveralls]

Pull Request Test Coverage Report for Build 3781

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 81.33%

---

Totals
Change from base Build 3778:	0.0%
Covered Lines:	4359
Relevant Lines:	5054

---

💛 - Coveralls

[patternfly-build]

PatternFly-React preview: https://1126-pr-patternfly-react-patternfly.surge.sh

[jschuler]

Seems package-lock.json should not have changed?

[jgiardino]

Thanks for looking into this, @ibolton336! @kmcfaul Has a similar update in #1014. I posted feedback in that PR when I reviewed her updates using different interaction methods.

Just to double-check, I also reviewed the preview for this PR. I'm getting the same results in both PRs for touch interaction:

• Testing on an iOS device, I can touch the toggle and collapse the menu. But touching anywhere outside the dropdown toggle or menu does not collapse the menu. Whereas with a mouse, I am able to click anywhere outside the toggle and menu to collapse the menu.

[ibolton336]

Thanks @jgiardino - do you think it would make sense to open a separate issue for handling the mobile bug for the dropdown not closing when touching outside of the dropdown focus?

[kmcfaul]

This fix is in PR #1014, but as it is undergoing edits for some unrelated fixes bundled with this one, I think this PR should be merged to get the fix out asap.

removed file

[jgiardino]

@kmcfaul That sounds good to me. Also, @ibolton336 raised the question of whether the issue with handling touch events on mobile should be a separate issue. It's currently noted in the issue you're working on for PR #1014, but I'm curious if you have thoughts on separating that out.

[ibolton336]

created #1131 to deal with the touch issues @jgiardino @kmcfaul