fix(codemod): fix tests failing due to prettier #1555
Conversation
|
LGTM. |
| const prettierConfig = { | ||
| ...prettier.resolveConfig.sync(process.cwd()), | ||
| parser: 'babel', | ||
| endOfLine: PRETTIER_EOL |
There was a problem hiding this comment.
Will this work under Windows? I think this was added to support that
https://github.com/patternfly/patternfly-react/pull/1255/files#r251540310
There was a problem hiding this comment.
I don't think our project even builds on Windows currently due to path resolution problems. I'd love to support it in the future and fix things like #478
There was a problem hiding this comment.
To answer the question, as long as a Windows machine doesn't convert the line-endings to CRLF in JSCodemod, it will still work.
Edit: But I have no way of testing that right now :(
|
PatternFly-React preview: https://1555-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=========================================
Coverage ? 83.62%
=========================================
Files ? 552
Lines ? 5751
Branches ? 12
=========================================
Hits ? 4809
Misses ? 940
Partials ? 2
Continue to review full report at Codecov.
|
|
Will create an issue to setup a Win environment possibly to test this going forward |
What: Remove prettier EOL config option during tests. Tests fail whenever it is specified on *nix-based systems after #1255
Additional issues: