Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EmptyState): Convert empty state to TypeScript #1917

Merged
merged 2 commits into from May 17, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented May 2, 2019

Refactored empty state to TypeScript.

Fixes #1991.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #1917 into master will decrease coverage by <.01%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
- Coverage   81.84%   81.84%   -0.01%     
==========================================
  Files         628      628              
  Lines        7112     7139      +27     
  Branches      236      243       +7     
==========================================
+ Hits         5821     5843      +22     
  Misses       1163     1163              
- Partials      128      133       +5
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.83% <89.13%> (+0.03%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...mponents/EmptyState/EmptyStateSecondaryActions.tsx 75% <75%> (ø)
...-core/src/components/EmptyState/EmptyStateBody.tsx 87.5% <87.5%> (ø)
...-core/src/components/EmptyState/EmptyStateIcon.tsx 92.3% <92.3%> (ø)
...eact-core/src/components/EmptyState/EmptyState.tsx 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883bea4...15e9fab. Read the comment docs.

@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:empty-typescript branch from 9abedff to b952967 May 17, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:empty-typescript branch from b952967 to 15e9fab May 17, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 17, 2019

Added test/demo and addressed PR feedback.

@dlabaj
dlabaj approved these changes May 17, 2019
Copy link
Contributor

dlabaj left a comment

Looks great. Thanks!

@tlabaj
tlabaj approved these changes May 17, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

}
}

export default EmptyStateDemo;

This comment has been minimized.

Copy link
@redallen

redallen May 17, 2019

Contributor

Remove export default

@dlabaj
dlabaj approved these changes May 17, 2019
@dlabaj dlabaj dismissed redallen’s stale review May 17, 2019

Rebecca updated with comments.

@dlabaj dlabaj merged commit 1fb9934 into patternfly:master May 17, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:empty-typescript branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.