feat(EmptyState): Convert empty state to TypeScript #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1917-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
==========================================
- Coverage 81.84% 81.84% -0.01%
==========================================
Files 628 628
Lines 7112 7139 +27
Branches 236 243 +7
==========================================
+ Hits 5821 5843 +22
Misses 1163 1163
- Partials 128 133 +5
Continue to review full report at Codecov.
|
|
@rebeccaalpert can you also add integration tests for this component as outlined on this README? |
redallen
suggested changes
May 15, 2019
packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateBody.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateBody.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateIcon.tsx
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateIcon.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateSecondaryActions.tsx
Outdated
Show resolved
Hide resolved
tlabaj
requested changes
May 16, 2019
packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateIcon.tsx
Outdated
Show resolved
Hide resolved
rebeccaalpert
force-pushed
the
empty-typescript
branch
from
9abedff
to
b952967
Compare
rebeccaalpert
force-pushed
the
empty-typescript
branch
from
b952967
to
15e9fab
Compare
|
Added test/demo and addressed PR feedback. |
redallen
previously requested changes
May 17, 2019
| } | ||
| } | ||
|
|
||
| export default EmptyStateDemo; |
dlabaj
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored empty state to TypeScript.
Fixes #1991.