Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(List): Convert list to TypeScript #1946

Merged
merged 3 commits into from
May 20, 2019

Conversation

rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented May 7, 2019

Converted to TypeScript.

Fixes #1994.

@rebeccaalpert rebeccaalpert added enhancement 🚀 PF4 React issues for the PF4 core effort labels May 7, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1946-pr-patternfly-react-patternfly.surge.sh

@nicolethoen
Copy link
Contributor

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add integration tests for ListVariant, List, ListProps, ListItem, and ListItemProps.

Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Can we use git mv to rename the primary component files instead of deleting and recreating them? If we can do this, we'll retain the ability to trace the history of these modules going forward which is important for tracking down when certain changes were made, by who, and why. Looks like you've done this for may of the component files already, if we could give the same treatment for the others that would be great.

@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #1946 into master will decrease coverage by 0.03%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
- Coverage   81.84%   81.81%   -0.04%     
==========================================
  Files         628      629       +1     
  Lines        7112     7116       +4     
  Branches      236      240       +4     
==========================================
+ Hits         5821     5822       +1     
  Misses       1163     1163              
- Partials      128      131       +3
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.73% <81.25%> (-0.07%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/LoginPage/LoginPage.tsx 63.63% <ø> (ø) ⬆️
...tternfly-4/react-core/src/components/List/index.ts 100% <100%> (ø)
...nfly-4/react-core/src/components/List/ListItem.tsx 50% <50%> (ø)
...tternfly-4/react-core/src/components/List/List.tsx 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883bea4...d5ca189. Read the comment docs.

@rebeccaalpert
Copy link
Member Author

Added demo and test. I also addressed @dlabaj's PR feedback. @seanforyou23, as noted on Slack, git mv doesn't seem to net a different outcome, so I'm leaving that as-is for now.

@rebeccaalpert rebeccaalpert requested a review from tlabaj May 16, 2019 19:23
@rebeccaalpert rebeccaalpert force-pushed the list-typescript branch 3 times, most recently from 0c9ba87 to 86b2327 Compare May 17, 2019 13:56
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Rebecca.

@dlabaj dlabaj merged commit ecb2702 into patternfly:master May 20, 2019
@rebeccaalpert rebeccaalpert deleted the list-typescript branch May 28, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🏠 PF4 React issues for the PF4 core effort TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert list to Typescript
8 participants