Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(List): Convert list to TypeScript #1946

Merged
merged 3 commits into from May 20, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented May 7, 2019

Converted to TypeScript.

Fixes #1994.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 7, 2019

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:list-typescript branch from 022d2df to dac5f27 May 7, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

Copy link
Contributor

dlabaj left a comment

Also add integration tests for ListVariant, List, ListProps, ListItem, and ListItemProps.

Copy link
Member

seanforyou23 left a comment

Awesome work! Can we use git mv to rename the primary component files instead of deleting and recreating them? If we can do this, we'll retain the ability to trace the history of these modules going forward which is important for tracking down when certain changes were made, by who, and why. Looks like you've done this for may of the component files already, if we could give the same treatment for the others that would be great.

@tlabaj tlabaj added chore 🏠 and removed enhancement 🚀 labels May 15, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:list-typescript branch from dac5f27 to 0cdb560 May 16, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #1946 into master will decrease coverage by 0.03%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
- Coverage   81.84%   81.81%   -0.04%     
==========================================
  Files         628      629       +1     
  Lines        7112     7116       +4     
  Branches      236      240       +4     
==========================================
+ Hits         5821     5822       +1     
  Misses       1163     1163              
- Partials      128      131       +3
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.73% <81.25%> (-0.07%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/LoginPage/LoginPage.tsx 63.63% <ø> (ø) ⬆️
...tternfly-4/react-core/src/components/List/index.ts 100% <100%> (ø)
...nfly-4/react-core/src/components/List/ListItem.tsx 50% <50%> (ø)
...tternfly-4/react-core/src/components/List/List.tsx 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883bea4...d5ca189. Read the comment docs.

@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented May 16, 2019

Added demo and test. I also addressed @dlabaj's PR feedback. @seanforyou23, as noted on Slack, git mv doesn't seem to net a different outcome, so I'm leaving that as-is for now.

@rebeccaalpert rebeccaalpert requested a review from tlabaj May 16, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:list-typescript branch 3 times, most recently from 0c9ba87 to 86b2327 May 17, 2019
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:list-typescript branch from 86b2327 to d5ca189 May 17, 2019
@dlabaj dlabaj self-assigned this May 17, 2019
@tlabaj
tlabaj approved these changes May 17, 2019
Copy link
Contributor

tlabaj left a comment

Looks great Rebecca.

@dlabaj
dlabaj approved these changes May 17, 2019
@dlabaj dlabaj merged commit ecb2702 into patternfly:master May 20, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rebeccaalpert rebeccaalpert deleted the rebeccaalpert:list-typescript branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.