Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Badge): Convert badge to typescript #2048

Merged
merged 2 commits into from May 21, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented May 21, 2019

Fixes #1986

Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 21, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   81.92%   81.92%   +<.01%     
==========================================
  Files         632      632              
  Lines        7279     7280       +1     
  Branches      337      338       +1     
==========================================
+ Hits         5963     5964       +1     
  Misses       1164     1164              
  Partials      152      152
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.16% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...f435407. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 21, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@b070e65). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2048   +/-   ##
=========================================
  Coverage          ?   81.85%           
=========================================
  Files             ?      632           
  Lines             ?     7342           
  Branches          ?      364           
=========================================
  Hits              ?     6010           
  Misses            ?     1163           
  Partials          ?      169
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 78.09% <66.66%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...2fa97f5. Read the comment docs.

Copy link
Contributor

redallen left a comment

Also add typescript: true to the md because I think it looks pretty :)

Jessie
@dlabaj
dlabaj approved these changes May 21, 2019
Copy link
Contributor

dlabaj left a comment

LGTM

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented May 21, 2019

It looks very pretty.

@redallen redallen merged commit 836f484 into patternfly:master May 21, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rachael-phillips rachael-phillips added this to the Albatross milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.