Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Badge): Convert badge to typescript #2048

Merged
merged 2 commits into from
May 21, 2019

Conversation

jessiehuff
Copy link
Contributor

Fixes #1986

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2048-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   81.92%   81.92%   +<.01%     
==========================================
  Files         632      632              
  Lines        7279     7280       +1     
  Branches      337      338       +1     
==========================================
+ Hits         5963     5964       +1     
  Misses       1164     1164              
  Partials      152      152
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.16% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...f435407. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b070e65). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2048   +/-   ##
=========================================
  Coverage          ?   81.85%           
=========================================
  Files             ?      632           
  Lines             ?     7342           
  Branches          ?      364           
=========================================
  Hits              ?     6010           
  Misses            ?     1163           
  Partials          ?      169
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 78.09% <66.66%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...2fa97f5. Read the comment docs.

Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add typescript: true to the md because I think it looks pretty :)

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen
Copy link
Contributor

It looks very pretty.

@redallen redallen merged commit 836f484 into patternfly:master May 21, 2019
@rachael-phillips rachael-phillips added this to the Albatross milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert badge component to typescript
6 participants