Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): remove ChartThemeDefinition export from index.ts #2149

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jun 4, 2019

A simple fix to remove the ChartThemeDefinition export from the ChartTheme index.ts file.

Fixes #2148

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 4, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #2149 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   80.51%   80.49%   -0.03%     
==========================================
  Files         650      649       -1     
  Lines        8234     8225       -9     
  Branches      610      610              
==========================================
- Hits         6630     6621       -9     
  Misses       1308     1308              
  Partials      296      296
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 75.75% <100%> (-0.06%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 62.82% <ø> (ø) ⬆️
...eact-charts/src/components/ChartAxis/ChartAxis.tsx 90.9% <ø> (ø) ⬆️
...ct-charts/src/components/ChartUtils/chart-theme.ts 62.5% <ø> (ø) ⬆️
...act-charts/src/components/ChartTheme/ChartTheme.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29aa5...5762281. Read the comment docs.

@dgutride dgutride merged commit 9929698 into patternfly:master Jun 4, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dlabrecq dlabrecq deleted the dlabrecq:2148-chart-theme-definition branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.