Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(form): wrap form label text in new element #2332

Merged
merged 1 commit into from
Jun 24, 2019
Merged

feat(form): wrap form label text in new element #2332

merged 1 commit into from
Jun 24, 2019

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Jun 24, 2019

What:

closes #2320

  • added a span.pf-c-form__label-text element under label.pf-c-form__label
  • updated unit tests snapshots

//cc @mcoker

@boaz0
feat(form): wrap form label text in new element
8a6e854 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2332.surge.sh

@jessiehuff jessiehuff merged commit b1301a3 into patternfly:master Jun 24, 2019
@boaz0
Copy link
Member Author

boaz0 commented Jun 25, 2019

Thank you @redallen and @jessiehuff !

@boaz0 boaz0 deleted the closes_2320 branch June 25, 2019 08:56
@christiemolloy christiemolloy mentioned this pull request Jun 25, 2019
Closed
@tlabaj
Copy link
Contributor

tlabaj commented Jun 25, 2019

Issue #2347 has been opened as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessiehuff jessiehuff jessiehuff approved these changes

@redallen redallen redallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap form label text in new element
5 participants
@boaz0 @patternfly-build @tlabaj @jessiehuff @redallen