Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): wrap form label text in new element #2332

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Jun 24, 2019

What:

closes #2320

  • added a span.pf-c-form__label-text element under label.pf-c-form__label
  • updated unit tests snapshots

//cc @mcoker

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 24, 2019

PatternFly-React preview: https://patternfly-react-pr-2332.surge.sh

@jessiehuff jessiehuff merged commit b1301a3 into patternfly:master Jun 24, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Jun 25, 2019

Thank you @redallen and @jessiehuff !

@boaz0 boaz0 deleted the boaz0:closes_2320 branch Jun 25, 2019
@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Jun 25, 2019

Issue #2347 has been opened as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.