Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): adds sparkline example and interpolation to area examples #2373

Merged
merged 1 commit into from
Jun 27, 2019
Merged

fix(charts): adds sparkline example and interpolation to area examples #2373

merged 1 commit into from
Jun 27, 2019

Conversation

dlabrecq
Copy link
Member

This adds a sparkline example and interpolation (curved lines) to other area examples.

See https://www.patternfly.org/pattern-library/data-visualization/sparkline/

fixes #2367

Screen Shot 2019-06-26 at 10 20 43 PM

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2373.surge.sh

boaz0
boaz0 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlabaj dlabaj requested a review from TheRealJon June 27, 2019 17:37
@dlabaj dlabaj self-assigned this Jun 27, 2019
@dlabaj dlabaj added PF4 React issues for the PF4 core effort enhancement 🚀 css review labels Jun 27, 2019
@dlabaj dlabaj requested a review from mcarrano June 27, 2019 17:40
mcarrano
mcarrano approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making these changes @dlabaj!

tlabaj
tlabaj approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit ac68f3f into patternfly:master Jun 27, 2019
@dlabrecq dlabrecq deleted the 2367-sparkline branch July 2, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boaz0 boaz0 boaz0 approved these changes

@dlabaj dlabaj dlabaj approved these changes

@mcarrano mcarrano mcarrano approved these changes

@tlabaj tlabaj tlabaj approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@dlabaj dlabaj

Labels
css review enhancement 🚀 PF4 React issues for the PF4 core effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sparkline example to Area chart
6 participants
@dlabrecq @patternfly-build @boaz0 @dlabaj @mcarrano @tlabaj