Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): adds sparkline example and interpolation to area examples #2373

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Jun 27, 2019

This adds a sparkline example and interpolation (curved lines) to other area examples.

See https://www.patternfly.org/pattern-library/data-visualization/sparkline/

fixes #2367

Screen Shot 2019-06-26 at 10 20 43 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jun 27, 2019

PatternFly-React preview: https://patternfly-react-pr-2373.surge.sh

@boaz0
boaz0 approved these changes Jun 27, 2019
Copy link
Member

boaz0 left a comment

LGTM 👍

@dlabrecq dlabrecq force-pushed the dlabrecq:2367-sparkline branch from 68a900b to f1988bb Jun 27, 2019
@dlabaj
dlabaj approved these changes Jun 27, 2019
@dlabaj dlabaj requested a review from TheRealJon Jun 27, 2019
@dlabaj dlabaj self-assigned this Jun 27, 2019
@dlabaj dlabaj requested a review from mcarrano Jun 27, 2019
Copy link
Member

mcarrano left a comment

Looks great. Thanks for making these changes @dlabaj!

@tlabaj
tlabaj approved these changes Jun 27, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit ac68f3f into patternfly:master Jun 27, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@dlabrecq dlabrecq deleted the dlabrecq:2367-sparkline branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.