Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ouia): add ouia to docs when statically rendering #2487

Closed
wants to merge 1 commit into from
Closed

fix(ouia): add ouia to docs when statically rendering #2487

wants to merge 1 commit into from

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Jul 9, 2019

What: Fixes #2477

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2487.surge.sh

jschuler
jschuler requested changes Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@jschuler jschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw OUIA attrs rendered by default

This was referenced Jul 9, 2019
Closed
Merged
@tlabaj tlabaj requested a review from dlabaj July 10, 2019 17:22
@tlabaj tlabaj added documentation 📝 PF4 React issues for the PF4 core effort labels Jul 10, 2019
@redallen
Copy link
Contributor Author

Closing in favor of #2478

@redallen redallen closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschuler jschuler jschuler requested changes

@dlabaj dlabaj Awaiting requested review from dlabaj

Assignees

@jschuler jschuler

Labels
documentation 📝 PF4 React issues for the PF4 core effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PF4: OUIA attrbiutes are not rendered if window.localStorage.ouia is true
4 participants
@redallen @patternfly-build @jschuler @tlabaj