Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration #2588

Merged
merged 5 commits into from
Jul 31, 2019
Merged

fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration #2588

merged 5 commits into from
Jul 31, 2019

Conversation

jenny-s51
Copy link
Contributor

What: Closes #2371.

@jenny-s51 jenny-s51 changed the title fix(select): add isPlain prop to Select and snapshot tests WIP: fix(select): add isPlain prop to Select and snapshot tests Jul 25, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2588.surge.sh

@jenny-s51 jenny-s51 changed the title WIP: fix(select): add isPlain prop to Select and snapshot tests fix(select): add isPlain prop to Select and snapshot tests Jul 25, 2019
@jenny-s51 jenny-s51 requested review from kmcfaul and tlabaj July 25, 2019 15:24
tlabaj
tlabaj previously requested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I would update the demo as well. It is good practice to verify that the props work in integration.

@tlabaj tlabaj added css review enhancement 🚀 PF4 React issues for the PF4 core effort labels Jul 25, 2019
@jenny-s51 jenny-s51 changed the title fix(select): add isPlain prop to Select and snapshot tests fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration Jul 29, 2019
@jenny-s51 jenny-s51 requested a review from tlabaj July 29, 2019 19:22
@tlabaj tlabaj requested a review from mcoker July 30, 2019 14:47
@jenny-s51 jenny-s51 dismissed tlabaj’s stale review July 30, 2019 15:01

Resolved in latest commit 🙂

@jenny-s51 jenny-s51 requested a review from redallen July 30, 2019 15:02
@redallen redallen merged commit 0809b28 into patternfly:master Jul 31, 2019
mcoker
mcoker reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jenny-s51 jenny-s51 deleted the iss2371 branch August 6, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker left review comments

@kmcfaul kmcfaul kmcfaul approved these changes

@redallen redallen redallen approved these changes

@tlabaj tlabaj Awaiting requested review from tlabaj

Assignees

@kmcfaul kmcfaul

Labels
css review enhancement 🚀 PF4 React issues for the PF4 core effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PF4 Select: The isPlain prop is missing
6 participants
@jenny-s51 @patternfly-build @mcoker @tlabaj @kmcfaul @redallen