Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration #2588

Merged
merged 5 commits into from Jul 31, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Jul 25, 2019

What: Closes #2371.

@jenny-s51 jenny-s51 changed the title fix(select): add isPlain prop to Select and snapshot tests WIP: fix(select): add isPlain prop to Select and snapshot tests Jul 25, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Jul 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2588.surge.sh

@jenny-s51 jenny-s51 changed the title WIP: fix(select): add isPlain prop to Select and snapshot tests fix(select): add isPlain prop to Select and snapshot tests Jul 25, 2019
@jenny-s51 jenny-s51 requested review from kmcfaul and tlabaj Jul 25, 2019
Copy link
Contributor

tlabaj left a comment

Looking good. I would update the demo as well. It is good practice to verify that the props work in integration.

@jenny-s51 jenny-s51 force-pushed the jenny-s51:iss2371 branch from deb8f4e to 0e5bec6 Jul 29, 2019
@jenny-s51 jenny-s51 changed the title fix(select): add isPlain prop to Select and snapshot tests fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration Jul 29, 2019
@jenny-s51 jenny-s51 requested a review from tlabaj Jul 29, 2019
@tlabaj tlabaj requested a review from mcoker Jul 30, 2019
@jenny-s51 jenny-s51 dismissed tlabaj’s stale review Jul 30, 2019

Resolved in latest commit 🙂

@jenny-s51 jenny-s51 requested a review from redallen Jul 30, 2019
@redallen redallen merged commit 0809b28 into patternfly:master Jul 31, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Copy link
Contributor

mcoker left a comment

👍

@jenny-s51 jenny-s51 deleted the jenny-s51:iss2371 branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.