Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change width="0" to width="" #2742

Merged
merged 3 commits into from
Aug 21, 2019
Merged

change width="0" to width="" #2742

merged 3 commits into from
Aug 21, 2019

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Aug 20, 2019 •
edited
Loading

What: Take @mcoker 's advice to close #2693

Additional issues:

@redallen redallen changed the title change width=0 to width="" change width="0" to width="" Aug 20, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2742.surge.sh

mcoker
mcoker approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@redallen redallen merged commit 2b652e1 into patternfly:master Aug 21, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-core@3.89.3
  • @patternfly/react-docs@4.10.19
  • @patternfly/react-inline-edit-extension@2.10.15
  • demo-app-ts@2.20.7
  • @patternfly/react-table@2.18.9
  • @patternfly/react-topology@2.7.40
  • @patternfly/react-virtualized-extension@1.1.126

Thanks for your contribution! 🎉

@keithjgrant keithjgrant mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessiehuff jessiehuff jessiehuff approved these changes

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PF4 Login Page background image doesn't show up in Firefox
4 participants
@redallen @patternfly-build @jessiehuff @mcoker