Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat(ImportFile): Add an ImportFile Component #278

Closed
wants to merge 6 commits into from

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Mar 19, 2018

What:
fix #241
A very early implementation of the ImportFile component.
There is no official design, only a proposed one:

The component receives the following props:

  • maxSize - Maximum size allowed of a single file in bytes
  • maxAmount - Maximum amount of files allowed
  • acceptedTypes - Supported file types, the types collection can be found here

Link to Storybook:
Storybook

I wrote the CSS myself, and since i'm not very experienced with the language, any recommendations are more than welcome

@glekner glekner added the review label Mar 19, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 978

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.391%

Totals Coverage Status
Change from base Build 964: 0.0%
Covered Lines: 1244
Relevant Lines: 1574

💛 - Coveralls

@glekner glekner closed this Mar 19, 2018
@glekner glekner removed the review label Mar 19, 2018
@glekner glekner deleted the feature-importfile branch March 19, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component - Import File
2 participants