Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(default-name): Added import-default-name eslint rule #286

Merged

Conversation

dmiller9911
Copy link
Contributor

@dmiller9911 dmiller9911 commented Mar 23, 2018

Added a rule to force the naming of the default import specified packages. This will fix
inconsistencies with variable names.

What:
Eslint rule for default imports

Link to Storybook:
N/A

Additional issues:
Piggybacks off of PR: #274

@dmiller9911 dmiller9911 changed the title Lint import default name style: Added import-default-name eslint rule Mar 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1044

  • 17 of 17 (100.0%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.663%

Totals Coverage Status
Change from base Build 1043: 0.0%
Covered Lines: 1256
Relevant Lines: 1585

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 23, 2018

Pull Request Test Coverage Report for Build 1063

  • 17 of 17 (100.0%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.663%

Totals Coverage Status
Change from base Build 1043: 0.0%
Covered Lines: 1256
Relevant Lines: 1585

💛 - Coveralls

@priley86
Copy link
Member

this is a wonderful first contribution @dmiller9911 👏 👏 👏 ... it's nice that this also works automagically with estlint --fix.

One minor request and I think this is a 🍏 ... can you use something like style(default-name): Added import-default-name eslint rule in the commit? We have this conventional changelong convention. npm run commit can help there for future...

Added a rule to force the naming of the default import specified packages. This will fix
inconsistencies with variable names.
@dmiller9911 dmiller9911 changed the title style: Added import-default-name eslint rule style(default-name): Added import-default-name eslint rule Mar 27, 2018
@jeff-phillips-18 jeff-phillips-18 merged commit 73eec56 into patternfly:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants