Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: New symbol for threshold #2884

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Sep 9, 2019

Created a new legend symbol for thresholds (i.e., horizontal indicators). This is slightly different than the existing dash symbol, which is typically used to show differences between current and previous data, where the dashed symbol represents previous data.

This is to help fix: #2797
Also see: #2796

New threshold sybmol
Screen Shot 2019-09-08 at 10 57 07 PM

Existing dash symbol
Screen Shot 2019-09-08 at 11 04 14 PM

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2884.surge.sh

@dlabrecq dlabrecq marked this pull request as ready for review September 9, 2019 13:50
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler jschuler merged commit 3ab27f0 into patternfly:master Sep 10, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@4.9.10
  • @patternfly/react-core@3.103.4
  • @patternfly/react-docs@4.12.8
  • @patternfly/react-inline-edit-extension@2.11.34
  • demo-app-ts@2.24.7
  • @patternfly/react-table@2.20.14
  • @patternfly/react-topology@2.8.33
  • @patternfly/react-virtualized-extension@1.2.22

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dash-threshold branch September 25, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF4: Charts - Horizontal Indicators
5 participants