Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo-app-ts): increase strict checks for react-integration #3222

Merged

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented Oct 28, 2019

What: This PR raises the strict checks used in react-integration package to the maximum degree possible before breaking anything. This should help prevent new issues from being introduced while we chip away at bringing the code into compliance with strictNullChecks, strictFunctionTypes, noImplicitAny, and strictPropertyInitialization compiler options.

It's a safe step toward solving #3223

…r react-integration
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #3222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3222   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         892      892           
  Lines       24872    24872           
  Branches     2142     2142           
=======================================
  Hits        16774    16774           
  Misses       7093     7093           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377ac47...6863d3f. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 28, 2019

PatternFly-React preview: https://patternfly-react-pr-3222.surge.sh

@tlabaj
tlabaj approved these changes Nov 5, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit f24a410 into patternfly:master Nov 5, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 5, 2019

Your changes have been released in:

  • patternfly-react-extensions@3.0.3
  • patternfly-react@2.39.7
  • @patternfly/react-console@2.0.3
  • @patternfly/react-catalog-view-extension@1.1.8
  • @patternfly/react-docs@4.16.12
  • @patternfly/react-inline-edit-extension@2.12.19
  • demo-app-ts@3.9.8
  • @patternfly/react-integration@3.9.2
  • @patternfly/react-table@2.24.19

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.