Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4: fix(README.md): provides URL location of workspace #3254

Merged
merged 2 commits into from Nov 6, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Nov 1, 2019

Temporary fix for #3154 (comment)

@jenny-s51 jenny-s51 requested review from seanforyou23 and redallen Nov 1, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 1, 2019

PatternFly-React preview: https://patternfly-react-pr-3254.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #3254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3254   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be35f9...0982d08. Read the comment docs.

Copy link
Member

boaz0 left a comment

👍

Copy link
Member

seanforyou23 left a comment

Thanks for doing this! I left a couple of questions/suggestions.

packages/patternfly-4/react-core/README.md Outdated Show resolved Hide resolved
packages/patternfly-4/react-core/README.md Outdated Show resolved Hide resolved
@jenny-s51

This comment has been minimized.

Copy link
Contributor Author

jenny-s51 commented Nov 4, 2019

@seanforyou23 Thank you for your helpful feedback Michael! I've updated the README according to your suggestions.

@jenny-s51 jenny-s51 requested review from boaz0 and seanforyou23 Nov 4, 2019
@jenny-s51 jenny-s51 changed the title PF4: fix(README.md): adds link to localhost:8000 PF4: fix(README.md): provides URL location of workspace Nov 4, 2019

```sh
yarn start:pf4
```

Go to localhost:8000.

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Nov 5, 2019

Member

Although adding more info to the README is a good thing, this does not appear to address the original issue? That is, the yarn start:dev command no longer confirms exactly where the app is running.

This also does not account for the example app running on a different port, should port 8000 already be occupied.

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Nov 5, 2019

Author Contributor

@dlabrecq Thank you for your feedback Dan! This has to do with something Zack addressed here: #3154 (comment) and I added that line based on what was agreed upon in this comment. But I see what you mean -- this PR won't necessarily close that issue.

Good point about the different port -- do you happen to know what port the app runs on if localhost:8000 is already occupied?

This comment has been minimized.

Copy link
@seanforyou23

seanforyou23 Nov 5, 2019

Member

@jenny-s51 if the port is already in use it prints to the console @patternfly/react-docs: Something is already running at port 8000. I think it used to be the case that an interactive console would take over and allow you to specify a different port, then proceed to launch the dev server using that new config. It seems to have regressed or been removed at some point.

I'm personally ok with pulling these changes in, but I agree it doesn't really fix the root cause. So, as long as we can leave the related issue open for future fixes we should be ok. @dlabrecq does this sound ok to you?

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Nov 6, 2019

Member

Ok, can leave that issue opened

Copy link
Member

seanforyou23 left a comment

👍

@seanforyou23 seanforyou23 merged commit 482dafe into patternfly:master Nov 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 6, 2019

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.10
  • @patternfly/react-core@3.120.7
  • @patternfly/react-docs@4.16.15
  • @patternfly/react-inline-edit-extension@2.12.21
  • demo-app-ts@3.9.10
  • @patternfly/react-table@2.24.21
  • @patternfly/react-topology@2.11.7
  • @patternfly/react-virtualized-extension@1.3.20

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.