-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): use patternfly-a11y #3339
Conversation
4338533
to
c8714b0
Compare
PatternFly-React preview: https://patternfly-react-pr-3339.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #3339 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 897 897
Lines 25120 25120
Branches 2173 2173
=======================================
Hits 16966 16966
Misses 7141 7141
Partials 1013 1013
Continue to review full report at Codecov.
|
Can you please add an issue for tracking purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your changes have been released in:
Thanks for your contribution! 🎉 |
Use new repo https://github.com/patternfly/patternfly-a11y which can be given a list of URLs to run aXe against.
Report formats are console, JUnit XML, and JSON.
Can test for errors aXe considers incomplete (like occluded element color contrast), or exclude them with
--noIncomplete
. Can aggregate JUnit results by component and React/Core using--agregate
.Closes #3366.