Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use patternfly-a11y #3339

Merged
merged 4 commits into from Dec 3, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Nov 21, 2019

Use new repo https://github.com/patternfly/patternfly-a11y which can be given a list of URLs to run aXe against.

Report formats are console, JUnit XML, and JSON.

Can test for errors aXe considers incomplete (like occluded element color contrast), or exclude them with --noIncomplete. Can aggregate JUnit results by component and React/Core using --agregate.

Closes #3366.

@redallen redallen force-pushed the redallen:chore/patternfly-a11y branch from 4338533 to c8714b0 Nov 21, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Nov 21, 2019

PatternFly-React preview: https://patternfly-react-pr-3339.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #3339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3339   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files         897      897           
  Lines       25120    25120           
  Branches     2173     2173           
=======================================
  Hits        16966    16966           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5016b5...600f046. Read the comment docs.

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Nov 26, 2019

Can you please add an issue for tracking purposes.

@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Dec 2, 2019

@dgutride @tlabaj @dlabrecq I fixed the merge conflict and added an associated issue.

@tlabaj
tlabaj approved these changes Dec 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 3282d33 into patternfly:master Dec 3, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 3, 2019

Your changes have been released in:

  • @patternfly/react-docs@4.16.49

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.