Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate import from the docs #3362

Merged

Conversation

isimluk
Copy link
Contributor

@isimluk isimluk commented Nov 28, 2019

Just look few lines above. It is already imported.

Thanks!
close: #3381

@isimluk isimluk force-pushed the remove-duplicate-import-from-docs branch from 32edeec to 9910d81 Compare November 28, 2019 09:12
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-3362.surge.sh

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #3362 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3362   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         896      896           
  Lines       25112    25112           
  Branches     2173     2173           
=======================================
  Hits        16958    16958           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bd323...9910d81. Read the comment docs.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit c84bbe5 into patternfly:master Dec 5, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.46
  • @patternfly/react-core@3.126.2
  • @patternfly/react-docs@4.16.53
  • @patternfly/react-inline-edit-extension@2.14.4
  • demo-app-ts@3.14.2
  • @patternfly/react-table@2.24.48
  • @patternfly/react-topology@2.11.34
  • @patternfly/react-virtualized-extension@1.3.47

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatatList: Remove duplicate imports from docs
5 participants