Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Update threshold props #3414

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Dec 16, 2019

Update default threshold stroke width and dash array props from PatternFly-core

Fixes #3369

Screen Shot 2019-12-16 at 3 29 57 PM

@dlabrecq dlabrecq requested a review from ddonahue007 Dec 16, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 16, 2019

PatternFly-React preview: https://patternfly-react-pr-3414.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3369-threshold branch from d2955ed to 62e7cc6 Dec 16, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #3414 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
- Coverage   67.12%   67.12%   -0.01%     
==========================================
  Files         903      903              
  Lines       25442    25445       +3     
  Branches     2243     2243              
==========================================
+ Hits        17079    17081       +2     
- Misses       7332     7333       +1     
  Partials     1031     1031
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.26% <40%> (ø) ⬆️
Impacted Files Coverage Δ
...rc/components/ChartTheme/themes/threshold-theme.ts 100% <ø> (ø) ⬆️
...s/src/components/ChartThreshold/ChartThreshold.tsx 66.66% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b96cde...62e7cc6. Read the comment docs.

@tlabaj
tlabaj approved these changes Dec 16, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Dec 17, 2019
@dlabaj dlabaj merged commit 43ef5be into patternfly:master Dec 17, 2019
9 checks passed
9 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_a11y_pf4 Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Dec 17, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.2.7
  • @patternfly/react-docs@4.16.68

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:3369-threshold branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.