Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove width attr from BackgroundImage filter element #3758

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

seanforyou23
Copy link
Collaborator

This PR removes the width attribute for the filter element in BackgroundImage. Looks like it could also be set to the default value of 120%, but omitting it also seems to work so taking that route. Should help clear console errors when using this component.

What: Closes #3250

@seanforyou23 seanforyou23 added the PF4 React issues for the PF4 core effort label Feb 17, 2020
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 17, 2020

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #3758 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3758   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files         785      785           
  Lines       10632    10632           
  Branches     2313     2313           
=======================================
  Hits         7545     7545           
  Misses       2656     2656           
  Partials      431      431
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 59.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...src/components/BackgroundImage/BackgroundImage.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81879c8...38a316d. Read the comment docs.

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen
Copy link
Contributor

I tried to remove this attribute a few months ago. I settled for setting it to "" instead of "0" because of a Firefox bug I think? (see #2693) However, this PR appears to work in Firefox.

If @mcoker approves, this is good by me and we should change the HTML in Core too.

@redallen redallen requested a review from mcoker February 21, 2020 15:57
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This was originally implemented due to an issue in Chrome - patternfly/patternfly#607

But I tested in chrome, safari, and firefox, and looks fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 React issues for the PF4 core effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF4: BackgroundImage produces console error
7 participants