-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove width attr from BackgroundImage filter element #3758
Conversation
PF3 preview: https://patternfly-react-pr-3758-pf3.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #3758 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 785 785
Lines 10632 10632
Branches 2313 2313
=======================================
Hits 7545 7545
Misses 2656 2656
Partials 431 431
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried to remove this attribute a few months ago. I settled for setting it to If @mcoker approves, this is good by me and we should change the HTML in Core too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This was originally implemented due to an issue in Chrome - patternfly/patternfly#607
But I tested in chrome, safari, and firefox, and looks fine!
This PR removes the
width
attribute for the filter element in BackgroundImage. Looks like it could also be set to the default value of 120%, but omitting it also seems to work so taking that route. Should help clear console errors when using this component.What: Closes #3250