fix(examples): make the interactions in the demo more life-like #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PF4 preview: https://patternfly-react-pr-4492.surge.sh |
jessiehuff
approved these changes
Jul 7, 2020
nicolethoen
approved these changes
Jul 8, 2020
mcarrano
approved these changes
Jul 8, 2020
dlabrecq
approved these changes
Jul 8, 2020
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #3337
This PR updates the example for "Split button action" of the Dropdown component, making the interactions trigger alerts instead of console logs so that users who are not developers can see the impacts of interacting with elements of the Dropdowns. I think it was already working as desired, just that it wasn't as obvious with the way the example was wired up.
We should probably swap all similar types of console logs in the docs to alerts for the same reason. I can do that in a separate PR if it's helpful.