fix(Toolbar): deleteChip expects categoryKey as string #4553
Conversation
| @@ -67,21 +67,23 @@ export class ToolbarFilter extends React.Component<ToolbarFilterProps, ToolbarFi | |||
| render() { | |||
| const { children, chips, deleteChipGroup, deleteChip, categoryName, showToolbarItem, ...props } = this.props; | |||
| const { isExpanded, chipGroupContentRef } = this.context; | |||
| const categoryKey = typeof categoryName === 'string' ? categoryName : categoryName.key; | |||
There was a problem hiding this comment.
Thinking we should test typeof ToolbarChipGroup before returning categoryName.key? (It's possible that key may not be defined for the given object.) That way, the string could be returned as the default.
There was a problem hiding this comment.
The only types valid for categoryName is string or ToolbarChipGroup which requires a key. So it should be safe
There was a problem hiding this comment.
Although categoryName is typed, users can still provide a different object (e.g., categoryName={myObject as any}). I'm just advocating that it's safer to test for the ToolbarChipGroup interface first (since you're already using typeof) and default to string; thus, avoiding a potential undefined exception.
|
PF4 preview: https://patternfly-react-pr-4553.surge.sh |
nicolethoen
force-pushed
the
deleteChip_params_change
branch
from
a07b801
to
95e61a6
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Closes #3552