Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-docs): title syntax #4628

Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix(react-docs): title syntax #4628

merged 1 commit into from
Jul 29, 2020

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Jul 29, 2020 •
edited
Loading

What: Followup to #4627. For the patternfly.org refactor we need to use the ### Example title syntax.

Additional issues:

evwilkin
evwilkin approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 29, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-4628.surge.sh
A11y report: https://patternfly-react-pr-4628-coverage.surge.sh

@redallen redallen merged commit 09dd6c5 into patternfly:master Jul 29, 2020
ddonahue007
ddonahue007 reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddonahue007 ddonahue007 ddonahue007 left review comments

@evwilkin evwilkin evwilkin approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@jschuler jschuler Awaiting requested review from jschuler

@seanforyou23 seanforyou23 Awaiting requested review from seanforyou23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@redallen @patternfly-build @evwilkin @kmcfaul @ddonahue007