-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): add medium variant #4678
Conversation
PF4 preview: https://patternfly-react-pr-4678.surge.sh |
Thanks @boaz0! Feature works well, but should we add an example to https://patternfly-react-pr-4678.surge.sh/documentation/react/components/modal? |
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@mcoker sure - no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙂 Also works with keyboard and VO/Safari!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #4526
//cc @mcoker