Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): skip the divider children in getDisplay #4998

Merged
merged 1 commit into from
Oct 13, 2020
Merged

fix(select): skip the divider children in getDisplay #4998

merged 1 commit into from
Oct 13, 2020

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Oct 11, 2020

What: Closes #4945

//cc @jenny-s51

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 11, 2020

@codecov-io
Copy link

Codecov Report

Merging #4998 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4998   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files         529      529           
  Lines        9718     9718           
  Branches     3580     3581    +1     
=======================================
  Hits         5070     5070           
  Misses       3995     3995           
  Partials      653      653           
Flag Coverage Δ
#patternfly4 52.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/react-core/src/components/Select/Select.tsx 41.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f889ee...7ae0d8e. Read the comment docs.

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - wise to add the new test

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 99fc494 into patternfly:master Oct 13, 2020
@boaz0
Copy link
Member Author

boaz0 commented Oct 14, 2020

Thank you all: @nicolethoen @dlabrecq and @tlabaj for reviewing!

@boaz0 boaz0 deleted the closes_4945 branch October 14, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: TypeError: Cannot read property 'toString' of undefined
6 participants