-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): skip the divider children in getDisplay #4998
Conversation
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
PF4 preview: https://patternfly-react-pr-4998.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #4998 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 529 529
Lines 9718 9718
Branches 3580 3581 +1
=======================================
Hits 5070 5070
Misses 3995 3995
Partials 653 653
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - wise to add the new test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you all: @nicolethoen @dlabrecq and @tlabaj for reviewing! |
What: Closes #4945
//cc @jenny-s51