feat(textarea): support isDisabled #5107
Conversation
|
PF4 preview: https://patternfly-react-pr-5107.surge.sh |
| @@ -10,11 +10,13 @@ export enum TextAreResizeOrientation { | |||
| both = 'both' | |||
| } | |||
|
|
|||
| export interface TextAreaProps extends Omit<HTMLProps<HTMLTextAreaElement>, 'onChange' | 'ref'> { | |||
| export interface TextAreaProps extends Omit<HTMLProps<HTMLTextAreaElement>, 'disabled' | 'onChange' | 'ref'> { | |||
There was a problem hiding this comment.
I'm in favor of this and I think it warrants finally having a "breaking type change" discussion I've been postponing.
There was a problem hiding this comment.
We should also add the isReadOnly prop. That is what the consumer seems to be looking for. Please see my comment in the issue. We want the consumers to still be able to use the native disabled or readOnly` attributes so we don't break them. Please add integration test to verify.
|
@tlabaj done! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #5107 +/- ##
=======================================
Coverage 52.40% 52.41%
=======================================
Files 541 541
Lines 9923 9925 +2
Branches 3696 3698 +2
=======================================
+ Hits 5200 5202 +2
Misses 4059 4059
Partials 664 664
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -124,6 +124,12 @@ export class TextAreaDemo extends React.Component<{}, TextAreaState> { | |||
| validated={validated} | |||
| aria-label="text area example 5" | |||
| /> | |||
| <Text>Disabled text area </Text> | |||
There was a problem hiding this comment.
can you update the cypress test to verify expected behaviour.
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
|
Hi @tlabaj, I added tests to cypress as you requested. Sorry for the late response 🙇 |
|
Thank you all! |
What: Closes #5068
It is a breaking change. If someone is using
disabledin the props then after updating with this change Typescript will show an error message sayingdisabledis not a valid props ofTextArea.