Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-charts): bump victory and move victory dep to demo app #5178

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix(react-charts): bump victory and move victory dep to demo app #5178

merged 1 commit into from
Nov 23, 2020

Conversation

redallen
Copy link
Contributor

What: Towards openshift/console#7287

Additional issues:

jcaianirh
jcaianirh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @redallen

@patternfly-build
Copy link
Contributor

patternfly-build commented Nov 23, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-5178.surge.sh
A11y report: https://patternfly-react-pr-5178-a11y.surge.sh

@jschuler jschuler merged commit 45ec687 into patternfly:master Nov 23, 2020
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@6.12.3
  • @patternfly/react-docs@5.10.75
  • demo-app-ts@4.60.5
  • @patternfly/react-integration@4.60.2

Thanks for your contribution! 🎉

dlabrecq
dlabrecq reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the import in chartLine.md?

import { VictoryZoomContainer } from 'victory';

@redallen redallen mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabrecq dlabrecq dlabrecq left review comments

@jschuler jschuler jschuler approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@redallen @patternfly-build @jschuler @dlabrecq @jcaianirh