Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart remains muted with interactive legend #5378

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

dlabrecq
Copy link
Member

When hovering over an interactive legend item, all other datasets in the chart are muted (i.e., an opacity is applied to make them look slightly grayed out). When the cursor moves away from the legend item, the muted styles are removed. This works fine with line and area charts, but there is a problem with bar charts. It's more of an edge case, but under certain conditions, bars may remain muted.

Fixes #5377

Cost Management
capture-good

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 27, 2021

Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen redallen merged commit b83995c into patternfly:master Feb 1, 2021
@dlabrecq dlabrecq deleted the 5377-interactive-bar-chart branch May 13, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar chart remains muted with interactive legend
4 participants