feat(Menu): add footer, add view more demo #5791
Conversation
|
PF4 preview: https://patternfly-react-pr-5791.surge.sh |
|
@jessiehuff Let me know what you think of the keyboard interactions so far, especially regarding the footer. The built in menu keyboard interaction currently only searches for all menu list items, so it would require adjustment to get the menu to cleanly navigate through outer elements with the arrow keys (if we wanted to go that way). It would be doable but a bit tricky. |
There was a problem hiding this comment.
The keyboard interaction looks really good with this!! You even shifted focus with the view more example which is awesome! 😄 I noticed some weirdness with VO on the view more example (when the view more button is pressed it didn't shift to the next item and said that the list is over). I'm going to try to investigate an aria-activedescendant approach that I wonder if would help this.
There was a problem hiding this comment.
I had difficulty getting my aria-activedescendant approach to work, and I don't want to hold up the PR for it so I created an issue for us to investigate that specific problem. Otherwise looks good! 🙂
What: Closes #5699
In this PR:
MenuFooterNotes:
Tabshifts focus between the active menu item and footer (as in the breadcrumb drilldown interaction). The content of the footer has no pre-built keyboard handling.ArrowUp/ArrowDownnavigates through the options list and the "view more" button as usual. The demo hooks in and manages theSpace/Enterkeydown for the "view more" button, focusing the next valid option from where the "view more" button used to be.