-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DescriptionList): add responsive layout breakpoint property #5885
Conversation
PF4 preview: https://patternfly-react-pr-5885.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Just one question about the prop/value names.
packages/react-core/src/components/DescriptionList/DescriptionList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Your changes have been released in:
Thanks for your contribution! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What: Closes #5445
layouts
property to specify layout orientation per breakpointsm
breakpoint tocolumnModifier
andautoFitMinModifier
autoFitModifier
(instead ofautoFitMinModifier
)