Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DescriptionList): add responsive layout breakpoint property #5885

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jun 7, 2021

What: Closes #5445

  • Adds layouts property to specify layout orientation per breakpoint
  • Adds sm breakpoint to columnModifier and autoFitMinModifier
  • Fixes example code using autoFitModifier (instead of autoFitMinModifier)

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 7, 2021

@kmcfaul kmcfaul changed the title Desclist layouts feat(DescriptionList): add responsive layout breakpoint property Jun 7, 2021
@tlabaj tlabaj requested a review from mcoker June 9, 2021 17:06
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Just one question about the prop/value names.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@tlabaj tlabaj self-assigned this Jun 17, 2021
@redallen redallen merged commit 0c51572 into patternfly:master Jun 17, 2021
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.11.50
  • @patternfly/react-code-editor@4.2.85
  • @patternfly/react-console@4.8.26
  • @patternfly/react-core@4.130.0
  • @patternfly/react-docs@5.18.64
  • @patternfly/react-inline-edit-extension@4.6.134
  • demo-app-ts@4.106.0
  • @patternfly/react-integration@4.107.0
  • @patternfly/react-log-viewer@4.1.27
  • @patternfly/react-table@4.27.33
  • @patternfly/react-topology@4.8.81
  • @patternfly/react-virtualized-extension@4.8.31

Thanks for your contribution! 🎉

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description list: responsive horizontal and vertical layout support
6 participants