Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TableComposable): Update Selectable example to use shift + select #6188

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

nicolethoen
Copy link
Contributor

What: Closes #6032

Updated Composable: Selectable example to implement a shift + select feature to demonstrate how to allow people to select intermediate rows all at once.

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 18, 2021

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolethoen This works well but only the first time I try it. If I select a range and then clear some items, shift-clicking again won't reselect them. I can only do that if I clear the selection and start over. I attached a video to demonstrate this.

Shift-Click.mov

Not totally sure what is correct, but I think that what I expected is that shift-select would always grab everything between my current item and last selected item. Does that make sense?

@nicolethoen
Copy link
Contributor Author

@mcarrano oh - it's working as I intended - but I realize that what your describing is how gmail works, so I can update that.

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Nicole. Works as expected.

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, also!

@tlabaj tlabaj merged commit 17a0a0f into patternfly:main Aug 19, 2021
@mturley
Copy link
Collaborator

mturley commented Aug 31, 2021

This is great, thanks @nicolethoen! It looks like it will probably fit right into my converted example as-is in #6168 once I rebase. This is also a great candidate feature for the useSelectionState hook I want to try and pitch as a PF extension soon! Could simplify this all to one function call. http://konveyor-lib-ui.surge.sh/?path=/docs/hooks-useselectionstate--checkboxes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Update composable checkbox demo
7 participants