-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TableComposable): Update Selectable example to use shift + select #6188
Conversation
PF4 preview: https://patternfly-react-pr-6188.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolethoen This works well but only the first time I try it. If I select a range and then clear some items, shift-clicking again won't reselect them. I can only do that if I clear the selection and start over. I attached a video to demonstrate this.
Shift-Click.mov
Not totally sure what is correct, but I think that what I expected is that shift-select would always grab everything between my current item and last selected item. Does that make sense?
@mcarrano oh - it's working as I intended - but I realize that what your describing is how gmail works, so I can update that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Nicole. Works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, also!
This is great, thanks @nicolethoen! It looks like it will probably fit right into my converted example as-is in #6168 once I rebase. This is also a great candidate feature for the |
What: Closes #6032
Updated Composable: Selectable example to implement a
shift + select
feature to demonstrate how to allow people to select intermediate rows all at once.