Add text input group demo #6581
Conversation
There was a problem hiding this comment.
This LOOKS great!!!
Some interaction issues, though.
I cannot select the key = Name. when I try to click it, it actually populates it with the key = Cluster. And if I type Name: none of the values appear as options.
I think it'll be important to be sure that if I user wanted to interact with this, using only the keyboard - they should be able to. If they wanted to ignore the dropdown completely that should be an option. And if they wanted to use the keyboard to select a key or value, they should be able to.
There was a problem hiding this comment.
This looks great @wise-king-sullyman ! Just a couple of questions/comments:
- The way that the chip gets cut off when it overflows feels odd. I'm talking about this:
But unfortunately I don't have a better suggestion. Anyone have any ideas?
- I understand why this is a demo for Text input group. And while that's technically correct, I doubt anyone would look for it there. Would we move it or link to it with a more descriptive title? What do you think @nicolethoen ?
|
@mcarrano an interaction question/suggestion was brought up by @nicolethoen in a conversation on slack:
This doesn't quite line up with my interpretation of the interaction proposal, but per @nicolethoen:
Is this functionality that you'd like to see added to this demo? |
@mcarrano I am always in favor of more explanation. Additionally, adding a few sentences before the demo to explain some of the interaction decisions you main or intended use cases you imagine this demo could satisfy would be helpful. |
bug occurred when using the mouse to select a menu item after filtering the menu items with the text input.
|
@wise-king-sullyman @nicolethoen regarding the question below...
The intended use case for this that I was modeling from ACM constrained the input to predefined attribute-value pairs. So you would not be able to create a chip with an unknown value. That said. there is probably another use case that is more like an auto-complete search where the user is offered a list of suggestions but can also enter any value from the keyboard and hit Enter to create a chip. Would it be possible to create a second demo that models this? I see these as different use cases and it would demonstrate the flexibility of this approach. |
There was a problem hiding this comment.
LGTM. Found a bug with the empty <TextInputGroupUtilities> element creating extra space that we can probably fix in core - patternfly/patternfly#4514
|
@mcarrano spinning up a second demo for that functionality is totally possible, though since code freeze was supposed to have happened already I'd like to do so in a new ticket next sprint if that's alright with you. |
|
That's fine @wise-king-sullyman . If you can open a new issue and tag me, I'll make sure it gets into the plan for the next milestone. Thanks. |
added support for text only key selection and focusing into the menu for arrow key based menu navigation.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #6393
Additional issues: patternfly/patternfly-design#1088
Interaction proposal:
