fix(log-viewer): update text selection behavior #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschuler
reviewed
Jan 6, 2022
|
User can also copy some section with mouse, then scroll away, and selection will be lost. I know it's expected due to virtualization, but mentioning it anyways since it's a related case. |
|
@jschuler Sounds interesting, yeah I only tested the trackpad selection situation. SHIFT+arrow key is inevitable. Do you have other better solutions? The requirement is here in this comment openshift/console#10486 (comment). |
jschuler
approved these changes
Jan 7, 2022
dlabrecq
approved these changes
Jan 10, 2022
nicolethoen
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6745